search

vmware / photon

Minimal Linux container host
https://vmware.github.io/photon
Other
3.02k stars 698 forks source link

Cloud-init patch is removing support for some cloud providers #1013

Open janitha opened 4 years ago

janitha commented 4 years ago

The cloud-init config looks to be explicitly disabling support for several cloud provider datasources.

https://github.com/vmware/photon/blob/9fabfaef381888700bbb9f963a3f17974102b1ee/SPECS/cloud-init/cloud-cfg.patch#L54-L61

I only noticed this while looking for something else, so I haven't reproduced the issue, but fairly certain https://vmware.github.io/photon/assets/files/html/3.0/photon_installation/set-up-PhotonOS-on-ec2.html cloud-init steps will work.

This may have been unintentionally introduced as part of 1104cc7f83cd5bbaaa50027b29114ca70d53b159 cc @sshedi

sshedi commented 4 years ago

Yes, I've commented them out and this was intentional. If you looks the https://github.com/vmware/photon/commit/1104cc7f83cd5bbaaa50027b29114ca70d53b159#diff-450f500954d5b84ef3b3ecfbf51ed805

I removed cloud-photon.cfg and in that config file, these were disabled. If you want any data source enabled by default, raise a PR with your requirements.

markpeek commented 4 years ago

Curious that there appear to be Photon images created for AWS, Azure, and GCP but the cloud-init for those platforms were commented out.

keerthanakalyan commented 4 years ago

@markpeek : Photon image-builder has custom photon cloud cfg files for building cloud images images. You can find those here: https://github.com/vmware/photon/blob/master/support/image-builder/ami/cloud-photon.cfg https://github.com/vmware/photon/blob/master/support/image-builder/ami/cloud-photon.cfg https://github.com/vmware/photon/blob/master/support/image-builder/gce/cloud-photon.cfg