search

vnattar / coltonlab

Automatically exported from code.google.com/p/coltonlab
0 stars 0 forks source link

Needle valve time estimate not quite right #63

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The Needle valve estimate that Steve implemented doesn't work quite right.
Error is manifested reproducibly when you close it from e.g. 20% open...
the display jumps to "0" immediately instead of counting down from 20 to 0
over the course of 15 seconds (or whatever the proper time would be).

Original issue reported on code.google.com by john.s.c...@gmail.com on 11 Aug 2009 at 7:36

GoogleCodeExporter commented 9 years ago

Original comment by AaronMit...@gmail.com on 28 Dec 2009 at 10:06

GoogleCodeExporter commented 9 years ago 
It seems Steve already fixed the program before I could get to it. The needle 
valve
also works fine now; it just gets a little stuck sometimes.

Original comment by AaronMit...@gmail.com on 4 Jan 2010 at 11:17

GoogleCodeExporter commented 9 years ago 

New observation from Feb 2010:
Needle valve percentage estimate still didn't work quite right: when going from 
35%
to 100%, the estimated % goes to zero, then starts counting up from there.

Original comment by john.s.c...@gmail.com on 4 Mar 2010 at 8:10

GoogleCodeExporter commented 9 years ago 
Double and triple-checked this. The old program had problems. The new version
estimates the % as it should, without skipping around. The only time the needle 
valve
skips is when you needle control to auto while the needle valve is moving. Then 
(on
auto), it automatically skips to the percent that you want it to go to. When you
toggle the needle valve back to manual, the "est. %" displays the true value of 
how
open the needle valve is.

The problem was with "Read Heater and Valve.vi." Now, "Read Heater and 
Valve.vi" uses
Steve's interpolating mathematics to calculate the "est. %" whether the needle 
valve
is set to "manual" or "auto". Before, it only interpolated when it was set to 
"manual."

There seem to be no problems with the needle valve est. %, now (virtually 
un-breakable).

Original comment by AaronMit...@gmail.com on 4 Mar 2010 at 11:06