search

vocdoni / ui-components

Vocdoni UI components libs
GNU General Public License v3.0
3 stars 2 forks source link

`connected` status in client hook is always true #113

Closed elboletaire closed 10 months ago

elboletaire commented 10 months ago

Review if it's being used, and reconsider it, since the "connected" status should refer to the signer and, considering it's not a dependency of this project (and developers can chose a different signer, like web3modal).

elboletaire commented 10 months ago

Not a problem with ui-components per se, but with ui-scaffold's implementation and due to this specific commit change: https://github.com/vocdoni/ui-scaffold/commit/4e82b5e82b5436ff78502db5c9af8679bb9f8872#diff-40491a231574238d24881f87242be2d9a48596bacf575caef1d6b624649f805fR30

Signer cannot be set as {} by default, that's why it was saying it's always connected. That, and because in the code is being checked as !!client.wallet, and that double negation generates a false positive when passing {} as signer.