search

voceconnect / multi-post-thumbnails

Adds multiple post thumbnails to a post type. If you've ever wanted more than one Featured Image on a post, this plugin is for you.
143 stars 63 forks source link

Remove i18n function from variable #130

Closed grappler closed 2 years ago

grappler commented 6 years ago

Variables cannot be translated like this. The text domain would be defined in theme.

The wiki could be updated with this instead.

if (class_exists('MultiPostThumbnails')) {
    new MultiPostThumbnails(
        array(
            'label' => __( 'Secondary Image', 'theme-text-domain' ),
            'id' => 'secondary-image',
            'post_type' => 'post'
        )
    );
}

Add text domain to plugin header as it is best practice.

grappler commented 6 years ago

I have also removed the de_DE translation as it was incomplete and it is not needed to be added the plugin due to language packs. The translation on https://translate.wordpress.org/projects/wp-plugins/multiple-post-thumbnails/dev/de/default is complete.

grappler commented 6 years ago

@chrisscott It would be great if you could merge this PR so that I can use the language packs from wp.org. Let me know if you have any questions.

chrisscott commented 6 years ago

Thanks @grappler ! I'm testing this out now...

grappler commented 5 years ago

@chrisscott Do you think you can merge these changes?

grappler commented 2 years ago

Closing due to no movement. Can reopen if needed.