search

void-linux / xbps

The X Binary Package System (XBPS)
https://voidlinux.org/xbps/
Other
822 stars 124 forks source link

xbps-query: add message when no packages have been found #501

Open OfekShochat opened 2 years ago

OfekShochat commented 2 years ago

closes #494

crtxcr commented 1 year ago

Just my opinion as another user:

While I too would like to see a message, this PR one is incomplete because:

1) misses a newline at the end of the printf 2) does not apply to -f and is therefore, inconsistent 3) prints to stdout, not stderr

I would argue it should also be shown without -v.

OfekShochat commented 1 year ago

sure. if I change those, will this be done?

JamiKettunen commented 1 year ago

No idea, you'd have to get an actual review from a Void Linux maintainer, in particular @Duncaen seems to be the one merging on this repo.