search

voiio / Sam

Sam – cuz your company is nothing without Sam
https://code.voiio.de/Sam/
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

Extend Algolia search parameters #75

Closed amureki closed 5 months ago

amureki commented 5 months ago

Can't make it properly work with dates yet.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 94.73%. Comparing base (c82278d) to head (439e6c0). Report is 8 commits behind head on main.

Files Patch % Lines
sam/contrib/algolia/tools.py 66.66% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #75 +/- ## ========================================== - Coverage 95.62% 94.73% -0.90% ========================================== Files 17 17 Lines 572 589 +17 ========================================== + Hits 547 558 +11 - Misses 25 31 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

amureki commented 5 months ago

I don't think we should add filters that are specific to our indexes. Unless we want Sam to search voiio explicitly. That might be cool if a customer sets up a bot like this.

yeah, there are more hard-locks on voiio that we need to fix. I'd be happy to change this, but we also need to introduce a proper plugin system.

amureki commented 5 months ago

We'll need to unify codebases first and then I will rework this internally.