search

volarjs / volar.js

💙🌊
https://volarjs.dev/
MIT License
1.02k stars 49 forks source link

The code of creating host by kit and language-server is inconsistent #45

Closed johnsoncodehk closed 5 months ago

johnsoncodehk commented 1 year ago

kit: https://github.com/volarjs/volar.js/blob/67faf9c5d06604899e362e441142a0c716567b9d/packages/kit/src/createProject.ts#L50 language server: https://github.com/volarjs/volar.js/blob/67faf9c5d06604899e362e441142a0c716567b9d/packages/language-server/src/common/project.ts#L193

We need to refactor the architecture to reuse code to avoid possible inconsistent behavior.

johnsoncodehk commented 5 months ago

Closed since this is no longer an issue.