Add nodejs v6 support to add command

volojs / volo

Create front end projects from templates, add dependencies, and automate the resulting projects

https://volojs.github.io/

Other

1.41k stars 100 forks source link

Add nodejs v6 support to add command #217

Closed kaleb closed 8 years ago

kaleb commented 8 years ago

path.basename throws an error in version 6 of node if the path argument is not a string. In my case the value was undefined. I found this error while attempting volo add requirejs/text.

jrburke commented 8 years ago

I can reproduce. I am having trouble getting the full test suite passing even with this change, so I'm still investigating that, but want to get a fix out over the coming weekend.

jrburke commented 8 years ago

I ended up committing the fix with some fixes to the tests to update to current URLs and such. v0.3.8 was released with this change, thanks for finding it!