search

voltrondata-labs / arrow-benchmarks-ci

Benchmarks CI for Apache Arrow project
MIT License
0 stars 5 forks source link

Switch to benchalerts #132

Closed austin3dickey closed 1 year ago

austin3dickey commented 1 year ago

Closes #98. This PR turns the Notification database table into BenchalertsRun, which keeps track of planned/historic benchalerts runs and knows how to run the benchalerts alerting pipeline, similar to how Notification was used in the past.

austin3dickey commented 1 year ago

I couldn't run an end-to-end test for this PR because it requires the DB migration. I think we can just merge this and I'll monitor and fix anything that comes up (or revert).

austin3dickey commented 1 year ago

Before I 🚢 this, I'll add the required GITHUB_APP_ID and GITHUB_APP_PRIVATE_KEY secrets to the schedule-and-publish Buildkite pipeline.

austin3dickey commented 1 year ago

Okay, all secrets should be set up now. The only thing I'm waiting on is for Apache Infra to install the GitHub app onto apache/arrow so it can post these checks.

austin3dickey commented 1 year ago

Looks like the app is installed: https://issues.apache.org/jira/browse/INFRA-24701