voltrondata-labs / arrow-benchmarks-ci

Benchmarks CI for Apache Arrow project
MIT License
0 stars 5 forks source link

The ArrowAlerter should not post ACTION_REQUIRED if all benchmarks get separated into "unstable" #158

Closed austin3dickey closed 1 year ago

austin3dickey commented 1 year ago

We recently had a check run posted that was triggered by @ursabot please benchmark lang=C++.

Since the ArrowAlerter separates all benchmark results into "stable" and "unstable", and reports on only the "stable" ones, and we treat C++ benchmarks as "unstable", this check run resulted in ACTION_REQUIRED because there were no "stable" results.

Ideally we probably should report on benchmarks that were explicitly asked for, even if they're unstable.