vordgi / kvco

Edit JSONs faster than ever. Just Run and Edit!
https://k-v.co
Other
2 stars 0 forks source link

feature request: add the new keys values down the tree #84

Closed zakidze closed 2 months ago

zakidze commented 2 months ago

example when i have a json with missing value in certain locale and i use inio to add the missing value

inio adds the missing value + key to the end

reason : when use gitadd and commit only new keys would be shown or added stuff

vordgi commented 2 months ago

What if u had:

{
  "example": {
    "key1": "value1"
  },
  "example2": {
    "key2": "value2"
  }
}

And add new key "example.key3"?

And git should always show changes only, no matter where they are

zakidze commented 2 months ago

i see that git example delete everything than add everything

zakidze commented 2 months ago

Screenshot_20240620_180844_Chrome

Screenshot_20240620_180834_Chrome

zakidze commented 2 months ago

look even if 1 line is change git delete everything and adds everything

zakidze commented 2 months ago

this make the review hard to get the changes

vordgi commented 2 months ago

There were 2 spaces, but after inio there 1 tab?

Do u use prettier or something like that?

zakidze commented 2 months ago

yes

Le jeu. 20 juin 2024, 18:11, Alexander Savelyev @.***> a écrit :

There were 2 spaces, but after inio there 1 tab?

Do u use prettier or something like that?

— Reply to this email directly, view it on GitHub https://github.com/vordgi/nimpl-inio/issues/84#issuecomment-2181166486, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOVF6FR7CXE3U6DYDUXRLPLZIMELXAVCNFSM6AAAAABJUKPZUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGE3DMNBYGY . You are receiving this because you authored the thread.Message ID: @.***>

zakidze commented 2 months ago

i use prettier

vordgi commented 2 months ago

The problem is that sometimes it format your code, sometimes its not. You can use husky and format it each time on precommit.

From my side I will think about inio format style

zakidze commented 2 months ago

so there is some incostincies between inio styles and inio styles

vordgi commented 2 months ago

Between inio formatting and prettier formatting*

And it is logical. Inio have no idea about your formatters and linters (and shouln't)

zakidze commented 2 months ago

whar you propose souloution for this

vordgi commented 2 months ago

For now - "You can use husky and format it each time on precommit" [by prettier to keep the same codestyle which declared in prettier rules]

But I will think in additional

vordgi commented 2 months ago

Closing this task because the problem is not in this (and this cannot be done for reasons described above).

Opened a task on indent style rules - #98

zakidze commented 2 months ago

you know better

PS: the adviece you told me about worked well i mean husky with prettier formating

at least reduced 6000 lines to 600 lines

zakidze commented 2 months ago

hope you tackle the search missing value on all project issue or , repititive keys issue

vordgi commented 2 months ago

I keep them in mind, looking for a suitable solution

zakidze commented 2 months ago

at least make a i18n dir like scan by dir

Le dim. 30 juin 2024, 21:01, Alexander Savelyev @.***> a écrit :

I keep them in mind, looking for a suitable solution

— Reply to this email directly, view it on GitHub https://github.com/vordgi/nimpl-inio/issues/84#issuecomment-2198683893, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOVF6FTIOXSUHFQRIJ52WQTZKBPYLAVCNFSM6AAAAABJUKPZUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGY4DGOBZGM . You are receiving this because you authored the thread.Message ID: @.***>

vordgi commented 2 months ago

Indent rules shipped. Configure it just like your prettier rules.

inio.config.js

module.exports = {
    indent: {
        size: 1,
        type: "tab",
    },
};