vormkracht10 / laravel-mails

Collect everything about sent mails in your Laravel app
MIT License
22 stars 3 forks source link

[Improvment]: Notifications & Resend #26

Closed benjaminhaeberli closed 1 week ago

benjaminhaeberli commented 1 month ago

What happened?

Hi ! I'm opening this issue because I would want to improve this package by adding support for Notifications in addition to Mails, but I want to be sure that it is in line with what you envisage for the future. I'd also like to add support for Resend.

Is this something you've thought about? Or are you used to using Mailables for emails and Notifications for everything else, without mixing the two?

How to reproduce the bug

PS : Discussions are note enabled on this repository, then Ask a question and Request a feature buttons are not working.

image

Package Version

-

PHP Version

8.3

Laravel Version

11.25

Which operating systems does with happen with?

No response

Notes

No response

markvaneijk commented 2 weeks ago

Hi @benjaminhaeberli,

Thanks for your message! I'm not sure if I understand your question completely.

Do you ask if we want to add features to log (specifically) notifications and resend them if needed?

If so, that would be out of scope, as this is focussed on e-mail only.

But.. if your sending e-mail notifications, it will already automatically logged by this package already and you can resend them if you want, because it is essentially an email.

benjaminhaeberli commented 1 week ago

Hi @markvaneijk ! My questions weren't clear sorry, I had two things in mind :

Sorry for the confusion !

markvaneijk commented 1 week ago

Every mail sent using Laravel is supported, it listens to an event that Laravel dispatches when sending an email. Using all framework related methods this will be fine, also for Mail Notifications 👍🏼

A driver for Resend is in the works.

benjaminhaeberli commented 1 week ago

Damn, perfect ! I close this issue then, thanks for your answer :)