Extraneous getargspec in vip_hci.config.utils_conf.py

vortex-exoplanet / VIP

VIP is a python package/library for angular, reference star and spectral differential imaging for exoplanet/disk detection through high-contrast imaging.

http://vip.readthedocs.io/

MIT License

70 stars 57 forks source link

Extraneous getargspec in vip_hci.config.utils_conf.py #609

Closed meressler closed 1 year ago

meressler commented 1 year ago

While installing on a fresh python-3.11.4, I got an error about getargspec not being available from the inspect module. I gather getargspec has been deprecated in favor of fullgetargspec. However, importing getargspec in line 20 is pointless as the only occurrence of getargspec is in some commented out code in line 251. I suggest deleting getargspec from the import (and maybe deleting the dead code around line 251).

IainHammond commented 1 year ago

i noticed this too and just deleted the getargspec import. I believe @Eixalde updated that part of the code so it should no longer be needed at all right?

VChristiaens commented 1 year ago

Hi @meressler - thanks for noticing this. This should be solved in the newly released v1.5.0, which includes a major OOP update and support for 3.11 (which was not the case until then).