Closed Sand-jrd closed 5 months ago
Attention: Patch coverage is 55.33981%
with 46 lines
in your changes are missing coverage. Please review.
Project coverage is 52.13%. Comparing base (
d9f1bef
) to head (3a9bbf6
).
Files | Patch % | Lines |
---|---|---|
vip_hci/psfsub/pca_fullfr.py | 35.00% | 26 Missing :warning: |
vip_hci/preproc/skysubtraction.py | 68.25% | 20 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @Sand-jrd !
Replacement the content of sci_cube_skysub with the DIKL procedure as explained in [REN23].
In
pca_fullfr
, themask_rdi
has been (re)-added to_adi_rdi_pca
and is used along withsci_cube_skysub
when it is provided. If not, it follows the procedure in place.The argument
mask_rdi
in docstring has been updated accordingly and reference to [REN23] have been added.Exemple :
To create masks
Usage with
pca