search

voxpupuli-archive / puppet-bacula

Bacula module to manage all components of bacula
https://forge.puppet.com/puppet/bacula
Apache License 2.0
38 stars 48 forks source link

Allowed dots in administrator e-mail adress #26

Closed VerosK closed 9 years ago

VerosK commented 11 years ago

E-mail address of mail_to parameter is validate by regexp. The regexp didn't allow to use dots in mailbox name. This patch fixes this problem.

puppetcla commented 10 years ago

Waiting for CLA signature by @VerosK

@VerosK - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html

VerosK commented 10 years ago

I think that submitted one-line patch can be considered trivial.

puppetcla commented 10 years ago

CLA signed by all contributors.

underscorgan commented 9 years ago

@VerosK thanks for the contribution, and sorry it took so long to get back to you. I think the regex should be '^[\w\.-]+@([\w-]+\.)+[\w-]+$' instead of '^[\w.-]+@([\w-]+\.)+[\w-]+$'. If you can update that we can get this patch merged for you.

VerosK commented 9 years ago

Fixed the patch and hopefully rebased it on current state of the module.

Use ddacc7c9351e3eff7d7faea2432dbe9de2f71cea for merge.

underscorgan commented 9 years ago

@VerosK I think you're still missing the escape character before the '.' you added to the regex, looks like it was correct in 44d5628 but then not in ddacc7c

VerosK commented 9 years ago

@mhaskel The two commits metioned contains same files with same content. They differ only in history.

I've squashed history to hide the intermediate buggy commit. So the right version should be ddacc7c9351e3eff7d7faea2432dbe9de2f71cea , the 44d5628e8803a481a6266d7947c9061705b9f785 refers to intermediate buggy commit.

underscorgan commented 9 years ago

@VerosK ok, I see they have the same content now, but this PR is not based off of ddacc7c, it's still pointing to 527cb0c which is missing the escape for the '.' It looks like ddacc7c is in the issue-26 branch of your fork but this PR is against your master. If you could either update your master branch or close this and open a new PR against your issue-26 branch we should be able to get this resolved.

VerosK commented 9 years ago

Closing the PR and going to prepare new one. (as #32 )