search

voxpupuli / puppet-gluster

Create and manage Gluster pools, volumes, and mounts
https://forge.puppet.com/puppet/gluster
MIT License
16 stars 72 forks source link

Allow volumes without replicas #168

Closed glorpen closed 6 years ago

glorpen commented 6 years ago

This PR is strongly based on work in #92 but it is updated to current master and with one more test.

Fixes #88 Closes #92

glorpen commented 6 years ago

Not sure if it is what you wanted; $options (and $_options) can be undef or array and is expected by code to be just that, I would only force string content with parameter type - Optional[Array[String]] but then gluster::volume::setting has non-typed parameter.

ekohl commented 6 years ago

I meant https://github.com/voxpupuli/puppet-gluster/blob/805e649702e09dc7be2d02d52ff622b9f990c422/manifests/volume.pp#L80

glorpen commented 6 years ago

well, there was a bug :)

ekohl commented 6 years ago

I had a look and I think that https://github.com/voxpupuli/puppet-gluster/pull/169 cleans up it a lot by using Puppet 4 language constructs. Haven't actually tested it so let's see if the tests pass :)

glorpen commented 6 years ago

@ekohl can we merge this? I think it would be nice since this PR contains changes from Dec 2016.

ekohl commented 6 years ago

Thanks!

glorpen commented 6 years ago

Big thanks :)