search

voxpupuli / puppet-gluster

Create and manage Gluster pools, volumes, and mounts
https://forge.puppet.com/puppet/gluster
MIT License
16 stars 72 forks source link

Fix unnecessarily setting gluster volume option repeatedly #196

Open runejuhl opened 5 years ago

runejuhl commented 5 years ago

Checks Gluster volume options against existing values to avoid repeatedly setting values.

Also adds these types:

And these functions:

bastelfreak commented 5 years ago

Thanks for the PR @runejuhl. Can you please add some tests for the datatypes?

runejuhl commented 5 years ago

You're welcome @bastelfreak -- I've pushed some improvements.

I'll be in front of a gluster cluster on Monday, I'll test it then and add some tests for the datatypes.

vox-pupuli-tasks[bot] commented 4 years ago

Dear @runejuhl, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @runejuhl, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @runejuhl, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

runejuhl commented 4 years ago

Fixed the merge conflict, still need to add tests as requested in https://github.com/voxpupuli/puppet-gluster/pull/196#issuecomment-497092987

vox-pupuli-tasks[bot] commented 4 years ago

Dear @runejuhl, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @runejuhl, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks