search

voxpupuli / puppet-gluster

Create and manage Gluster pools, volumes, and mounts
https://forge.puppet.com/puppet/gluster
MIT License
16 stars 72 forks source link

fix puppet-lint warnings / switch to facts hash / drop legacy gluster versions 4.0 and older #203

Open bastelfreak opened 5 years ago

bastelfreak commented 5 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

ekohl commented 5 years ago

https://github.com/voxpupuli/puppet-gluster/commit/f76482e390d0aed1693d1eb4960cd9da71ce3d78 cleans it up a bit further.

NITEMAN commented 4 years ago

Hi, just asking, is there any chances this reaching official repo soon? May I help somehow?

vox-pupuli-tasks[bot] commented 4 years ago

Dear @bastelfreak, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @bastelfreak, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @bastelfreak, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

runejuhl commented 4 years ago

I've rebased this in https://github.com/runejuhl/puppet-gluster/tree/bugfix, but I noticed that https://github.com/voxpupuli/puppet-gluster/pull/203/commits/20decb51ad014a16c0554ff0dd057766009a452f removes a bunch of class specs -- is that in error or is it deliberate?