search

voxpupuli / puppet-gluster

Create and manage Gluster pools, volumes, and mounts
https://forge.puppet.com/puppet/gluster
MIT License
16 stars 72 forks source link

Add ubuntu support #239

Closed shieldwed closed 2 years ago

shieldwed commented 2 years ago

Pull Request (PR) description

Add support to install Gluster from their PPA to get more up-to-date versions than included in Ubuntu universe repository.

shieldwed commented 2 years ago

How can I move this PR forward?

smortex commented 2 years ago

Regarding the "Puppet 6 - Ubuntu 18.04" failure, you can apply this (same issue with another module, mind adjusting the comment): https://github.com/voxpupuli/puppet-puppetboard/commit/7366b4e3a5e29c1dd769a31caf48d75a2b2d648f

Debian 9 has reached EOL, if we can't fix it we can remove it. But it would be best to fix Debian 9, then in another PR add support for current Debian versions, and last in another PR drop support for Debian 9.

shieldwed commented 2 years ago

@smortex

Regarding the "Puppet 6 - Ubuntu 18.04" failure, you can apply this (same issue with another module, mind adjusting the comment): voxpupuli/puppet-puppetboard@7366b4e

Thanks very much. I just applied the patch and Ubuntu is now working properly.

Debian 9 has reached EOL, if we can't fix it we can remove it. But it would be best to fix Debian 9, then in another PR add support for current Debian versions, and last in another PR drop support for Debian 9.

I've applied the same condition for the release variable I needed for Ubuntu, and hence improved some Debian code. Additionally, this should also allow Gluster version 10 to be installed properly.

shieldwed commented 2 years ago

Is there anything more I can do to move this PR forward?