search

voxpupuli / puppet-icinga2

Puppet module to manage Icinga 2
https://forge.puppet.com/icinga/icinga2
Apache License 2.0
61 stars 94 forks source link

Fix namespaced Functions of stdlib #738

Closed cocker-cc closed 1 year ago

cocker-cc commented 1 year ago

Stdlib deprecated some non-namespaced Functions. So use the namespaced ones.

cla-bot[bot] commented 1 year ago

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @cocker-cc

- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please [contact us](https://icinga.com/company/contact/) if you think this is the case. - If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.
cocker-cc commented 1 year ago

Regarding the CLI, see this Conversation.

lbetz commented 1 year ago

funny, is included in branch release/v4.0.0.

lbetz commented 1 year ago

I know you and about CLA. And I understand you.

Did you notice that the stdlib with stdlib::merge only really works correctly higher than version 9.0.0?

lbetz commented 1 year ago

refs #730

cocker-cc commented 1 year ago

Did you notice that the stdlib with stdlib::merge only really works correctly higher than version 9.0.0?

What do you mean by "works correctly"?
stdlib::merge was introduced only since version 9.0.0

In this PR I did set 9.0.0 as a Requirement.

lbetz commented 1 year ago

You are absolutely right, I was mistaken. I thought I saw the code in earlier versions too.