search

voxpupuli / puppet-icingadb

Puppet module to manage IcingaDB.
Apache License 2.0
3 stars 6 forks source link

Add missing redis module dependency #43

Closed trauta closed 3 days ago

trauta commented 4 days ago

Hi,

just a small hint, unfortunately there is no hint in the documentation that this module depends on the upstream puppet-redis module.

I think this should be added to the requirements section in the README file for example.

lbetz commented 4 days ago

This module uses the class icinga::redis and so depends on module puppet-icinga. The module puppet-icinga uses redis and so that module depends on puppet-redis.

lbetz commented 4 days ago

Sorry, you're right. The defined resource of type redis::instance is also used so the dependency is really misssing.