search

voxpupuli / puppet-kmod

manage kernel module with puppet
Apache License 2.0
17 stars 63 forks source link

Add a path parameter to the execs for egrep and modprobe in load.pp #25

Closed madkiss closed 9 years ago

madkiss commented 10 years ago 
In its current incarnation, with puppet 3.7, the module fails to perform
the expected tasks with the following error message:

Error: Failed to apply catalog: Parameter unless failed on Exec[modprobe
kvm_intel]: 'egrep -q '^kvm_intel ' /proc/modules' is not qualified and
no path was specified. Please qualify the command or specify a path. at
/opt/puppet-upstream/kmod/manifests/load.pp:28

Error: Failed to apply catalog: Validation of Exec[modprobe kvm_intel]
failed: 'modprobe kvm_intel' is not qualified and no path was specified.
Please qualify the command or specify a path. at
/opt/puppet-upstream/kmod/manifests/load.pp:28

The problem here appears to be the fact that the full paths to both the
modprobe and egrep binaries are not specified. Adding the "path" param
to the exec calls resolves the issue.
raphink commented 10 years ago

Thank you. We are used to specifying path in a resource default in site.pp. However, I will probably merge this, if you could avoid repeating command (which is a namevar) and squash the commits.

jpds-zz commented 9 years ago

This fixed the module for me on Ubuntu 14.04.

saimonn commented 9 years ago

fixed with aa98ccd