search

voxpupuli / puppet-postfix

Puppet postfix module
Apache License 2.0
70 stars 172 forks source link

Fix typos errors in postfix::satellite from PR 326 #333

Closed cruelsmith closed 2 years ago

cruelsmith commented 2 years ago

Pull Request (PR) description

Fixes variable typos that has been added with Pull Request #326.

This is just cosmetic since this values are also pick_default inside postfix::mta and does result to the same catalog on the systems even when it here results to pass undef to postfix::mta.

Note for this Change these Lines, that are not used but now will with this PR: https://github.com/voxpupuli/puppet-postfix/blob/f3978930db8055a54bf75118b11a0d5e8dcfd1d7/manifests/satellite.pp#L43-L45

This Pull Request (PR) fixes the following issues

None

rwaffen commented 2 years ago

hm using the right variables breaks a lot of tests 🤔

cruelsmith commented 2 years ago

Test are failing because pick_default converts undef into an empty string that we do not want to allow: https://tickets.puppetlabs.com/browse/MODULES-6534

IMHO we just should remove these lines here and will be fine https://github.com/voxpupuli/puppet-postfix/blob/f3978930db8055a54bf75118b11a0d5e8dcfd1d7/manifests/satellite.pp#L43-L45

rwaffen commented 2 years ago

or switch to .lest method 🤔 like in your linked ticket