search

voxpupuli / puppet-pxe

Puppet module for deploying a PXE boot server
https://forge.puppet.com/puppet/pxe
51 stars 38 forks source link

add mfsbsd variants, ver > 10, docs and validation #30

Closed cruwe closed 7 years ago

cruwe commented 7 years ago

Hi,

While working with newer mfsbsd images, I thought the mfsbsd-resource could use some love:

mfsbsd has for some versions variants mfsbsd, mfsbsd-se and mfsbsd-mini. Add Possible os-versions for the image-provider.

mm@ has changed the path for mfsbsd > 10, Adapt path var accordingly.

Add some doc stubs for better understanding and add some basic validation to check parameters passed.

modified:   manifests/images.pp
modified:   manifests/images/mfsbsd.pp

I noticed you had the FreeBSD and Friends test commented out, so I did not bother much about testing. While developing, I did lots of provisioning with test-kitchen and the puppet plugin, but did not go further. Thanks for your work on this and the other puppet modules. Cheers

zachfi commented 7 years ago

This looks good, thanks for the PR. Please rebase to get the fix for json_pure issue. Ping me once its updated and I'll come back soonish.

I'm not sure about the commented test case. This module could use some spec tests, but that can begin in a different PR.

Hope the module is useful to you. Cheers.

cruwe commented 7 years ago

Hi ... done as requested :-) Cheers and a premature "Happy New Year"!

zachfi commented 7 years ago

Ah, great, you as well thanks!