search

voxpupuli / puppet-squid

Puppet module for configuration of squid caching proxy.
https://forge.puppet.com/puppet/squid
Other
12 stars 54 forks source link

support forwarded for #137

Closed ssanden closed 5 years ago

ssanden commented 5 years ago

Pull Request (PR) description

right now the param "forward_for" is a boolean that allows to set "on" or "off". Squid however can be configured using one of the values: "on", "off", "transparent", "delete", "truncate". this PR adds support for this.. also see: http://www.squid-cache.org/Doc/config/forwarded_for/

seems to work for me, please consider to merge it. thanks.

ekohl commented 5 years ago

Currently this would be a breaking change and I'm a bit hesititant to release a major version. Have you thought about compatibility?

It also looks like the tests are failing. Could you also have a look at adding one for the new values?

ssanden commented 5 years ago

hi @ekohl, thanks for the feedback. i added some updates for backward compatibility. cheers

traylenator commented 5 years ago

Looks good I'd say and that's nice way of avoiding one the if, elses, I'll steal that for the future.

Some tests with the new values would be good.

Currently there are zero docs for

ssanden commented 5 years ago

thanks for your feedback. i added the suggested code from the review and also some tests and the supported values in the readme. please have another look.