voxpupuli / puppet-squid

Puppet module for configuration of squid caching proxy.
https://forge.puppet.com/puppet/squid
Other
12 stars 54 forks source link

Remove default empty string parameters #169

Closed traylenator closed 2 years ago

traylenator commented 2 years ago

Pull Request (PR) description

For the defined types and parameters

This is backwards compatible for all cases except when options has been explicitly set to '' but I feel that is a non-case?

e.g.

squid::http_port{80:
  options => '',

would fail.

Resolves the linter issues for params_empty_string_assignment.

Extra commits include:

traylenator commented 2 years ago

Think I read accept' tests for 8 are currently broken somewhere....

traylenator commented 2 years ago

After After https://github.com/voxpupuli/puppet-squid/pull/170