Avoid Type=notify for squid service in github CI

voxpupuli / puppet-squid

Puppet module for configuration of squid caching proxy.

https://forge.puppet.com/puppet/squid

Other

12 stars 54 forks source link

Closed traylenator closed 2 years ago

traylenator commented 2 years ago

squid is failing to start on CentOS 8 acceptance tests with a timeout.

Avoid Type=notify for squid service as it seems the notification never gets there within Gitlab CI even if the service does start.

traylenator commented 2 years ago

Ugh, I don't like this but unfortunately have nothing better to propose and it fix CI so… LGTM?

Indeed.

Couple of extra things that could be done:

Is there a suitable fact so we could use to do this only in gitlab CI. virtual=kvm does not seem great.
Could add an additional test without the extra drop file where we expect it to fail. This would catch if the situation is fixed in the future. It's not obvious why this broke. Previous squid package on C8 also used notify.

traylenator commented 2 years ago

pending test added, that will also catch if Type=notify turns out to work on CentOS 9 when it is added.

traylenator commented 2 years ago

@smortex okay with the extra addition?

smortex commented 2 years ago

I am fine with this :-)