voxpupuli / puppet-vmwaretools

Puppet module to manage VMware Operating System Specific Packages for VMware tools installation.
http://forge.puppetlabs.com/razorsedge/vmwaretools
Apache License 2.0
34 stars 44 forks source link

RHEL6 complaints about service startup when using esx 5.0 #21

Closed technologistpro closed 10 years ago

technologistpro commented 10 years ago

When running on RHEL6 and esx5.0 ... err: /Stage[main]/Vmwaretools/Service[vmware-tools-services]/ensure: change from stopped to running failed: Could not start Service[vmware-tools-services]: Execution of '/sbin/start vmware-tools-services' returned 1: at /etc/puppetlabs/puppet/modules/vmwaretools/manifests/init.pp:287 ... It is trying to use /sbin/start instead of /sbin/service /vmware-tools-services start

The problem is in the regex, it is using one or more instead of zero or more, the fix is to change + to *:

  $rhel_upstart = $tools_version ? {
    /3\..+/   => false,
    /4\..+/   => false,
   ### /(5.0).+/ => false,
    /(5.0).*/ => false,
    default   => true,
  }
razorsedge commented 10 years ago

This is solved in #22.