search

voxpupuli / puppet-vmwaretools

Puppet module to manage VMware Operating System Specific Packages for VMware tools installation.
http://forge.puppetlabs.com/razorsedge/vmwaretools
Apache License 2.0
34 stars 44 forks source link

Scsitimeout #41

Closed adrenlinerush closed 8 years ago

adrenlinerush commented 8 years ago

This gives the ability to adjust the scsi timeout value that is set by the vmware tools installer.

acjohnson commented 8 years ago

@razorsedge are you able to review this PR?

razorsedge commented 8 years ago

@adrenlinerush The two commits of your PR (7cfa83cb7c53e14ac5a75f58e3c39a9e2162cf61 and 278d3ae97399d29bed6bc0e68ac5bcc095f73d51) look good. However, you managed to pick up a lot of the merge branches that already exist in master. Was your scsitimeout branch created from master or develop?

adrenlinerush commented 8 years ago

I was based off the master branch, I can re-base off the develop branch.

adrenlinerush commented 8 years ago

Re- based...

acjohnson commented 8 years ago

+1 @razorsedge please review

acjohnson commented 8 years ago

I just tested this and it appears we are missing some things... On RHEL 5 the udevadm binary is missing, so you must use udevcontrol instead:

# EL5
# /sbin/udevcontrol reload_rules

However on RHEL 5, 6 and 7 simply re-loading the udev rules is not enough to set the SCSI timeout dynamically, you must run start_udev as well to make the new rules go into effect:

# EL 5,6, and 7 - Make udev rules go in to effect
# /sbin/start_udev

Example:

# sed -i 's/echo 180 /echo 14400 /g' /etc/udev/rules.d/99-vmware-scsi-udev.rules

# udevadm control --reload-rules

# cd /sys

# find . -name timeout
./devices/pci0000:00/0000:00:15.0/0000:03:00.0/host2/target2:0:0/2:0:0:0/timeout
./devices/pci0000:00/0000:00:15.0/0000:03:00.0/host2/target2:0:1/2:0:1:0/timeout

# cat './devices/pci0000:00/0000:00:15.0/0000:03:00.0/host2/target2:0:0/2:0:0:0/timeout'
180

# cat './devices/pci0000:00/0000:00:15.0/0000:03:00.0/host2/target2:0:1/2:0:1:0/timeout'
180

# /sbin/start_udev
Starting udev:                                             [  OK  ]

# cat './devices/pci0000:00/0000:00:15.0/0000:03:00.0/host2/target2:0:0/2:0:0:0/timeout'
14400

# cat './devices/pci0000:00/0000:00:15.0/0000:03:00.0/host2/target2:0:1/2:0:1:0/timeout'
14400
razorsedge commented 8 years ago

@adrenlinerush Can you incorporate these findings into your PR?

adrenlinerush commented 8 years ago

Yeah, that's been added except I used the udev control trigger instead of udev_start for other than RHEL5.

razorsedge commented 8 years ago

Excellent.

One last, minor bit: can you update the README and the puppetdoc in the head of init.pp with the parameter details?

adrenlinerush commented 8 years ago

I think I got the doc updated.

razorsedge commented 8 years ago

@adrenlinerush Nice work.

adrenlinerush commented 8 years ago

@razorsedge when do you plan to make your next release?

razorsedge commented 8 years ago

razorsedge/vmwaretools 5.1.0 has been released to the Forge.