voxpupuli / puppet-vmwaretools

Puppet module to manage VMware Operating System Specific Packages for VMware tools installation.
http://forge.puppetlabs.com/razorsedge/vmwaretools
Apache License 2.0
34 stars 44 forks source link

5.0latest tree for rhel5 & rhel6 yanked by vmware #5

Closed ryanycoleman closed 12 years ago

ryanycoleman commented 12 years ago

On my CentOS 5 system (Puppet Learning VM), using the following declaration:

class { 'vmwaretools': autoupgrade => true, } include vmwaretools::ntp

The following repository is generated:

[vmware-tools] name=VMware Tools 5.0latest - rhel5 i686 baseurl=http://packages.vmware.com/tools/esx/5.0latest/rhel5/i686/ enabled=1 gpgcheck=1 gpgkey=http://packages.vmware.com/tools/keys/VMWARE-PACKAGING-GPG-DSA-KEY.pub http://packages.vmware.com/tools/keys/VMWARE-PACKAGING-GPG-RSA-KEY.pub protect=0 priority=50

The problem is, VMWare has killed the links for rhel5 & rhel6 in the *latest tree, suggesting the use of direct releases until they've fixed an upgrade issue. See http://packages.vmware.com/tools/esx/5.0latest/rhel5 for example.

I guess the question is, should one wait it out or should the module change to use absolute releases instead of *latest?

razorsedge commented 12 years ago

Grrr, stupid YUM bugs. VMware has them documented here: http://packages.vmware.com/tools/docs/engineering-release-notes/rhel-upgrade I am tempted to make this URL the default baseurl: http://packages.vmware.com/tools/esx/latest/

razorsedge commented 12 years ago

Try to set '5.0latest' in params.pp to 'latest'. If that works, then I will set this as the default in the next release.

razorsedge commented 12 years ago

@rcoleman Any confirmation on if this fix works?

ryanycoleman commented 12 years ago

@razorsedge I've declared the following:

class { 'vmwaretools': tools_version => '5.1', }

This correctly sets the tools version in the URL but the architecture still gets set to i686 on my i386 architecture CentOS VM which isn't a valid url. Perhaps that should be tweak-able as well? :-/

ryanycoleman commented 12 years ago

This line is my culprit: https://github.com/razorsedge/puppet-vmwaretools/blob/4.1.0/manifests/params.pp#L118

ryanycoleman commented 12 years ago

FWIW, your master branch resolves this issue. I'll await a new Forge release.

razorsedge commented 12 years ago

Fixed in Forge 4.1.1 release.