search

voxpupuli / puppet-windowsfeature

Library that uses ServerAdministration api that comes with Windows Server 2008 and Windows Server 2012 to add / remove windows features
https://forge.puppet.com/puppet/windowsfeature
MIT License
30 stars 50 forks source link

The restart parameter has been deprecated in favor of the puppetlabs reboot module ( https://github.com/puppetlabs/puppetlabs-reboot ). This parameter will be removed in the next release. (location: C:/ProgramData/PuppetLabs/puppet/cache/lib/puppet/type/windowsfeature.rb:20:in `block (2 levels) in <top (required)>') shows every run #120

Closed rychannel closed 5 years ago

rychannel commented 6 years ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

What are you seeing

Every run on the Puppet Agent displays the following error message "The restart parameter has been deprecated in favor of the puppetlabs reboot module ( https://github.com/puppetlabs/puppetlabs-reboot ). This parameter will be removed in the next release.

(location: C:/ProgramData/PuppetLabs/puppet/cache/lib/puppet/type/windowsfeature.rb:20:in `block (2 levels) in <top (required)>')"

What behaviour did you expect instead

I'd expect this message to show if I was using the restart parameter anywhere. But I'm not and this message shows up on all of my servers with every run

Output log

Any additional information you'd like to impart

rychannel commented 6 years ago

Really my main issue, is that its causing panic when folks that don't understand Puppet see this in the event viewer on servers and think Puppet is restarting their servers every 1/2 hour.

Also, I don't like being constantly warned about something I'm not using.

rychannel commented 5 years ago

What version will the fix be available in Puppet Forge?

TraGicCode commented 5 years ago

The latest version will have this now.