voxpupuli / puppet-windowsfeature

Library that uses ServerAdministration api that comes with Windows Server 2008 and Windows Server 2012 to add / remove windows features
https://forge.puppet.com/puppet/windowsfeature
MIT License
30 stars 50 forks source link

(GH-85) Fix typo in provider for source parameter #85

Closed glennsarti closed 7 years ago

glennsarti commented 7 years ago

Previously if a source parameter was specified it was not actually appended to the PowerShell command. This commit updates the command generation to use the correct resource name and fixes a typo in the comments

TJM commented 7 years ago

We have tested this code and had success on 2012R2, as the .net 3.5 (Net-Framework-Core) feature requires a source. The current release (2.1.0) does not pass the parameter to the powershell command.

Iristyle commented 7 years ago

Ping @igalic / @vinzent - thanks!

igalic commented 7 years ago

thanks for the ping and sorry for neglecting this._.

would anyone be able to add a test here?

TJM commented 7 years ago

For what its worth, this has already been fixed in "master"

glennsarti commented 7 years ago

@TJM Are you saying this already fixed in this repo in master branch? Can you link to the commit?

TJM commented 7 years ago

https://github.com/voxpupuli/puppet-windowsfeature/commit/2841db2806de1189a443bfebff3d17bf7d485c87

... admittedly they didn't fix the typo in the comment for the type, but thats fairly minor ;)

glennsarti commented 7 years ago

@igalic Additional tests in this case are not required. Already covered in https://github.com/voxpupuli/puppet-windowsfeature/blob/2841db2806de1189a443bfebff3d17bf7d485c87/spec/unit/puppet/provider/windowsfeature/default_spec.rb#L112-L126

This is a typo fix. Even though resource['source'] works, it is not consistent with previous lines and looks confusing because the unless statement is using @resource[:source]

glennsarti commented 7 years ago

Note this PR is not required to be merged prior to a release of the feature work in #81 but would be nice to have.