search

vpenades / SharpGLTF

glTF reader and writer for .NET Standard
MIT License
454 stars 72 forks source link

AttenuationDistance incorrect default value #215

Closed BoyBaykiller closed 5 months ago

BoyBaykiller commented 5 months ago

https://github.com/vpenades/SharpGLTF/blob/7744baca9425c537513300887c752e074f338671/src/SharpGLTF.Toolkit/Materials/MaterialEnums.cs#L192

By KHR_materials_volume, shouldn't the default value of AttenuationDistance be set to float.PositiveInfinity? It currently is 0.0 which I think is incorrect.

vpenades commented 5 months ago

I think you're right, I'll fix the code to the correct values.