vsco / keys

Keys for Adobe Photoshop Lightroom
http://vsco.github.io/keys/
GNU General Public License v2.0
341 stars 63 forks source link

Work with OS X Catalina? #39

Open GabrielNavasA opened 4 years ago

GabrielNavasA commented 4 years ago

Just wondering if anyone updated to Catalina? Keys still working? Thanks!

GabrielNavasA commented 4 years ago

I tried to install VSCO Keys on a Catalina but I couldn't make it work. These are the lines that appear in the log.

TRACE error:errorCode = "cannotConnectToHost" nativeCode = "-1004"

Any ideas?

Thanks!

bwehman commented 4 years ago

Nope, it killed VSCO keys for me. DAMMIT.

rpolczer commented 4 years ago

Same here. I guess it is due to the 32/64 bit change.

GabrielNavasA commented 4 years ago

But I understand VSCO Keys is 64bits.

5tarForge commented 4 years ago

I updated to Catalina without thinking VSCO Keys would be affected :(

GabrielNavasA commented 4 years ago

and it doesn't work, doesn't it?

snaphappy commented 4 years ago

Glad I found this, if it doesn't work there's no way I'm updating to Catalina

bwehman commented 4 years ago

Every time an OS or LR has a significant update, VSCO Keys breaks. I've decided with this one to just move on...sadly...I found an app called PFixer Core that not only includes the same VSCO key layouts, but lets you customize anything. Pretty great. I've been using it in my editing workflow for the last couple weeks and it's been pretty much seamless.

snaphappy commented 4 years ago

Every time an OS or LR has a significant update, VSCO Keys breaks. I've decided with this one to just move on...sadly...I found an app called PFixer Core that not only includes the same VSCO key layouts, but lets you customize anything. Pretty great. I've been using it in my editing workflow for the last couple weeks and it's been pretty much seamless.

I bought pfixer two years ago but the values between adjustments could not be altered. For example, if you pressed a key to increase the blacks, it would go up a set amount, maybe like +5, and the software wouldn't allow me to change the value, for example to +1 or something similar. Has that changed?

ilquare commented 4 years ago

Hi guys, do you have any news? VSCO keys + OS X Catalina does not work .... are there solutions? Only switch to PFixer Core

DFStockel commented 4 years ago

Every time an OS or LR has a significant update, VSCO Keys breaks. I've decided with this one to just move on...sadly...I found an app called PFixer Core that not only includes the same VSCO key layouts, but lets you customize anything. Pretty great. I've been using it in my editing workflow for the last couple weeks and it's been pretty much seamless.

I bought pfixer two years ago but the values between adjustments could not be altered. For example, if you pressed a key to increase the blacks, it would go up a set amount, maybe like +5, and the software wouldn't allow me to change the value, for example to +1 or something similar. Has that changed?

I stopped trying a few OS' ago, but I used Keyboards Maestro to give me the same functionality as VSCO Keys did. So PFixer and Key Maestro together gives me the same performance I had with VSCO Keys. I edit over 400k images year, so it's a big deal to me!

heyklaus commented 4 years ago

Hi @DFStockel, this sounds intriguing. Do you have some more details to share? How is this all set up? I would actually only need to move some sliders around with the keyboard, and apply some presets. How does your setup look like? Thanks for your help!

cajames commented 4 years ago

Hey all,

I've added support for macOS Catalina for Lightroom Classic 9. If you're interested, you can download the latest version here: https://github.com/cajames/keys/releases/tag/v2.0.3-alpha

Please let me know if you have any issues. I've tested it on:

macOS Catalina 10.15.1 Lightroom Classic 9.1

bwehman commented 4 years ago

System requires password to grant VK keyboard access. I enter password but still unable to run the app.

cajames commented 4 years ago

@bwehman Did you uninstall the previous version before installing this? Please be sure to remove the LR plugin too from Lightroom, and install the new plugin.

Then the app should start when Lightroom starts. Let me know if that isn't the case. Also, could you mention what version of macOS, and Lightroom you're using.

(Previously documented upgrade steps: https://github.com/vsco/keys/issues/28#issuecomment-352030080)

heyklaus commented 4 years ago

Fresh install on a new Catalina machine with LR classic 9.1 running, and this works like a charm. You're amazing @cajames. Thank you so much and keep that good work up!

GabrielNavasA commented 4 years ago

I just installed the new version of VSCO Keys on a Catalina with LR 9 and it works fine! I had to give full disk access permissions in Security in the system preferences so that it does not ask for the password when booting Lr. Thank you very much for your help @cajames!!

bwehman commented 4 years ago

Hmm, still having issues. Everytime LR boots, VK requests the system password, and when entered, does nothing. Running same as you, 10.15.1 and LR 9.1. I added VK to the list of full disk access and accessibility access in security too. Strange. Also added as an LR plugin.

Do you think there's an issue having PFixer installed too? It's not running while all this is occurring, but still, just a thought.

rachaelblack commented 4 years ago

@bwehman Did you uninstall the previous version before installing this? Please be sure to remove the LR plugin too from Lightroom, and install the new plugin.

Then the app should start when Lightroom starts. Let me know if that isn't the case. Also, could you mention what version of macOS, and Lightroom you're using.

(Previously documented upgrade steps: #28 (comment))

@cajames I'm pretty sure you saved my editing life in 2017 with a similar current working download of VK... I just downloaded this new one (Thanks, btw) but am getting an error msg when I click to install. Running Catalina 10.15.2 and LR 9.0 Release. The error message is in the screenshot attached.

Screenshot 2019-12-29 19 17 30
cajames commented 4 years ago

@rachaelblack Oh wow that's interesting, It looks like Catalina is a lot stricter with how apps get signed. It seems to be an issue a number of apps are facing. Thank you for bringing it to my attention. :)

This should be signed with my Apple developer account, but I'll have a look at what changes I need to make and re-release. @heyklaus @GabrielNavasA did you guys have this issue?

@rachaelblack I'll update here as soon as I have new signed version up.

GabrielNavasA commented 4 years ago

Hi @rachaelblack. Any issue with the version’s @cajames. I installed it on Catalina with LR 9 and it works perfectly!

rachaelblack commented 4 years ago

Hi @rachaelblack. Any issue with the version’s @cajames. I installed it on Catalina with LR 9 and it works perfectly!

Yeah, I’m not sure what the issue is, but it’s definitely not installing seamlessly and I seem to have hit a snag. Thanks @cajames for offering a fix. I’ll be checking back frequently. I appreciate you!!!

bwehman commented 4 years ago

Yeah, same here. Snag city. Appreciate the efforts of course!

On Dec 30, 2019, at 1:53 PM, rachaelblack notifications@github.com wrote:

Hi @rachaelblack https://github.com/rachaelblack. Any issue with the version’s @cajames https://github.com/cajames. I installed it on Catalina with LR 9 and it works perfectly!

Yeah, I’m not sure what the issue is, but it’s definitely not installing seamlessly and I seem to have hit a snag. Thanks @cajames https://github.com/cajames for offering a fix. I’ll be checking back frequently. I appreciate you!!!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vsco/keys/issues/39?email_source=notifications&email_token=AH3JUAIOEY7ISA22IPIPMUTQ3JUVTA5CNFSM4I6PKTBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH3JCAI#issuecomment-569807105, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3JUALULKMO6CCTXMBKXRDQ3JUVTANCNFSM4I6PKTBA.

heyklaus commented 4 years ago

Yeah, I think I got the some message. But If I remember correctly, opening via the context menu worked. Anyway, I am still a happy VSCO Keys user.

abstractconformity commented 4 years ago

Yeah, same here. Snag city. Appreciate the efforts of course!

I'm also having this issue.

Catalina 10.15.2 LR Classic 9.1

Deleted all of the previous VSCO Keys. Uninstalled the plugin in LR Opened and installed via context menu Added the LR plugin Closed and restarted the computer

It asks for my password upon opening LR, but nothing happens beyond that and the plugin manager says its running. Any help?

snaphappy commented 4 years ago

@bwehman Did you uninstall the previous version before installing this? Please be sure to remove the LR plugin too from Lightroom, and install the new plugin. Then the app should start when Lightroom starts. Let me know if that isn't the case. Also, could you mention what version of macOS, and Lightroom you're using. (Previously documented upgrade steps: #28 (comment))

@cajames I'm pretty sure you saved my editing life in 2017 with a similar current working download of VK... I just downloaded this new one (Thanks, btw) but am getting an error msg when I click to install. Running Catalina 10.15.2 and LR 9.0 Release. The error message is in the screenshot attached.

Screenshot 2019-12-29 19 17 30

Rachael, after you double click and get the pop up that says "can't be opened because Apple cannot check for malicious software" immediately open System Preferences -> Security & Privacy and then make sure you're on the "General" tab (it's to the left of FileVault). Now that you're on the General tab, down at the bottom there should be an option to install VSCO Keys and override the security pop-up, worked perfectly for me!!

snaphappy commented 4 years ago

All of my code works perfectly EXCEPT tint & temperature... check out my code below, why doesn't it work?

{ "mod":"0", "key":"12", "adj" : {"Tint":"-1"} }, { "mod":"0", "key":"13", "adj" : {"Tint":"1"} }, { "mod":"0", "key":"14", "adj" : {"Temperature":"-100"} }, { "mod":"0", "key":"15", "adj" : {"Temperature":"100"} },

rachaelblack commented 4 years ago

@bwehman Did you uninstall the previous version before installing this? Please be sure to remove the LR plugin too from Lightroom, and install the new plugin. Then the app should start when Lightroom starts. Let me know if that isn't the case. Also, could you mention what version of macOS, and Lightroom you're using. (Previously documented upgrade steps: #28 (comment))

@cajames I'm pretty sure you saved my editing life in 2017 with a similar current working download of VK... I just downloaded this new one (Thanks, btw) but am getting an error msg when I click to install. Running Catalina 10.15.2 and LR 9.0 Release. The error message is in the screenshot attached.

Screenshot 2019-12-29 19 17 30

Rachael, after you double click and get the pop up that says "can't be opened because Apple cannot check for malicious software" immediately open System Preferences -> Security & Privacy and then make sure you're on the "General" tab (it's to the left of FileVault). Now that you're on the General tab, down at the bottom there should be an option to install VSCO Keys and override the security pop-up, worked perfectly for me!!

Thanks for the help. I was able to get @cajames 's download/update to install and working with your help. I'm dancing a jig!! :)

leifniem commented 4 years ago

This works perfectly @cajames i think you should put your version up as a PR :)

Ian1969 commented 4 years ago

@bwehman I seem to be running into exactly the same issues as you. Followed the instructions step by step and it's just not having it. Tries to launch, Lightroom says it's running but...nothing. Did you manage to find a solution? I'm running Catalina 10.15.1 - Lightroom 9.1.

leifniem commented 4 years ago

@Ian1969 i had to manually add the app as an accessibility helper in the System settings two times over, even if i was presented with a dialog for it. I don't know if closing Lightroom was necessary but if you have not tried that you might want to.

Ian1969 commented 4 years ago

@leifniem thats absolutely nailed it. Added it 2 times as an accessibility helper with Lightroom closed and it's now all working. Thanks so much for the tip!

rpolczer commented 4 years ago

@cajames amazing, thank you for the update.

One thing I noticed that the ESC key method to activate / deactivate the plugin does not work. Is it only for me or a general problem? I am at Catalina 10.15.3 (19D76) + LR Classic 9.1.

EDIT - it was a local issue and a system reboot solved it. Thank again ! :)

yatheesh999 commented 4 years ago

if you use vsco keys after making changes to photos it completely resets the the photo to original, ( LRC 9.3 Version / 2.0.3 alpha keys)

even reinstalling doesnt slove the issue

snaphappy commented 4 years ago

if you use vsco keys after making changes to photos it completely resets the the photo to original, ( LRC 9.3 Version / 2.0.3 alpha keys)

even reinstalling doesnt slove the issue

Having the same issue since updating to 9.3 :( Really stinks

rachaelblack commented 4 years ago

if you use vsco keys after making changes to photos it completely resets the the photo to original, ( LRC 9.3 Version / 2.0.3 alpha keys)

even reinstalling doesnt slove the issue

Questions on this.... Did you notice the issue when you updated to Catalina (with Lr in the 9.2 version) or did the problem occur when BOTH were updated? I'm asking because this thread made me examine my system and updates and my main editing computer (my iMac) was set to auto-update the iOS, but not Creative Cloud. Obviously, I don't auto-update, so I imagine this was changed automatically during my last iOS update. CC is definitely NOT set on my end to auto-update. Hope we can resuscitate KEYS after these software updates.

heyklaus commented 4 years ago

Questions on this.... Did you notice the issue when you updated to Catalina (with Lr in the 9.2 version) or did the problem occur when BOTH were updated?

Same issue here since I updated to LR Classic 9.3 a few days ago. Had been on Catalina 10.15.4 already, no issues so far. So it's the current Adobe update which causes the problems. Local adjustments get reset when applying VSCO keys (other changes like spot removal, crop etc. seem to remain untouched, though). Any ideas, @cajames ?

cajames commented 4 years ago

Hi all, thanks for reporting this issue. Could you please help me reproduce it? I'm currently testing it on LRC 9.3, though I'm not able to see it. Not sure if my settings are different somehow.

Here's what I'm currently doing to try to recreate this issue based on what I've read above:

Here's a video of what I'm doing for clarity: lightroom-9 3

I've tested this on LRC 9.3 on Mojave 10.14.6, and Catalina 10.15.5, using the VSCO Keys 2.0.3-alpha release.

If I understand correctly, I should expect all the other values I've changed to reset?

Could you please describe how I can reproduce this issue and what the expected behaviour should be, or perhaps record a video showing what you're experiencing?

heyklaus commented 4 years ago

Hi @cajames, thank you so much for looking into the issue. In my case, the sliders are fine, they keep their position. The only issue appears with local adjustments. LRC 9.3 on 10.15.4 using VSCO Keys 2.0.3. Here's a video: https://www.dropbox.com/s/q18qg0qmd6idy6j/vsco.mov?dl=0

yatheesh999 commented 4 years ago

Hi all, thanks for reporting this issue. Could you please help me reproduce it? I'm currently testing it on LRC 9.3, though I'm not able to see it. Not sure if my settings are different somehow.

Here's what I'm currently doing to try to recreate this issue based on what I've read above:

  • Import an image
  • Make some changes to the image using the sliders on the right
  • Then use VSCO keys to edit a value (e.g. increase exposure)

Here's a video of what I'm doing for clarity: lightroom-9 3

I've tested this on LRC 9.3 on Mojave 10.14.6, and Catalina 10.15.5, using the VSCO Keys 2.0.3-alpha release.

If I understand correctly, I should expect all the other values I've changed to reset?

Could you please describe how I can reproduce this issue and what the expected behaviour should be, or perhaps record a video showing what you're experiencing?

if you use radial filter/graduated filter or brush then you try to adjust white balance or exposure by keys it reverts back to original image with out changes applied prior to that.

abstractconformity commented 4 years ago

That’s the exact issue I’m having. It’s only occurring post filter.

John On Jun 26, 2020, 12:16 -0500, yatheesh999 notifications@github.com, wrote:

Hi all, thanks for reporting this issue. Could you please help me reproduce it? I'm currently testing it on LRC 9.3, though I'm not able to see it. Not sure if my settings are different somehow. Here's what I'm currently doing to try to recreate this issue based on what I've read above:

• Import an image • Make some changes to the image using the sliders on the right • Then use VSCO keys to edit a value (e.g. increase exposure)

Here's a video of what I'm doing for clarity: I've tested this on LRC 9.3 on Mojave 10.14.6, and Catalina 10.15.5, using the VSCO Keys 2.0.3-alpha release. If I understand correctly, I should expect all the other values I've changed to reset? Could you please describe how I can reproduce this issue and what the expected behaviour should be, or perhaps record a video showing what you're experiencing? if you use radial filter/graduated filter or brush then you try to adjust white balance or exposure by keys it reverts back to original image with out changes applied prior to that. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

cajames commented 4 years ago

Hi all, thanks for your help in identifying the issue. I think I've found what changed in Lightroom Classic 9.3 and I've built a fix for it in the VSCO keys plugin. I've tested this change in LRC 9.3 and hopefully should solve this issue.

You can download the latest version here: https://github.com/cajames/vsco-keys/releases/tag/v2.0.5

Please let me know if you have any issues with this release. Please be sure to uninstall your previous versions, and remove the old plugin from Lightroom, and then install the new version and LR Plugin.

If you're interested, I've documented the issue and fixes here: https://github.com/cajames/vsco-keys/pull/4 and https://github.com/cajames/vsco-keys/pull/5.

I also raised my concerns in the Adobe forum, and it was replicated by other members as a bug in the Adobe SDK. I've raised this bug report with Adobe.

yatheesh999 commented 4 years ago

working!! thanks for the update.

hybridvision commented 4 years ago

Hey @cajames,

I just wanted to add my heartfelt thanks for all the work you've been doing to keep this project alive and updated :) I'm using Lightroom Classic 9.3 on Mac OS 10.14.6 and your latest update is working nicely.

I don't understand why Adobe doesn't make these kinds of tasks easier but I guess they're not interested in a minority of users who want this functionality. At least we still have this as an option!

cajames commented 4 years ago

I just wanted to add my heartfelt thanks for all the work you've been doing to keep this project alive and updated :) I'm using Lightroom Classic 9.3 on Mac OS 10.14.6 and your latest update is working nicely.

@hybridvision my pleasure! And that's very kind of you to say. Happy to hear these updates I make helps people. 😊

I don't understand why Adobe doesn't make these kinds of tasks easier but I guess they're not interested in a minority of users who want this functionality. At least we still have this as an option!

And I know what you mean, it can get tiring. I guess Adobe's software suite is complex in its own right, so they're bound to break things here and there. I just wish they were better at communicating what they change. Though in their defence, they reached out to me pretty quickly after I raised the fact they introduced a bug in their SDK, so that's good. How long it'll take them to fix the issue might be another story. 😝

Anyway, in the meantime, I've worked around it so we should be okay. 😊 Let me know if you face any issues and I'll be happy to help!

hybridvision commented 4 years ago

Thanks for the offer of further help, @cajames, I appreciate it!

I'm still figuring out how best to use VSCO Keys so I've been digging through the code to understand what is possible. I had one problem where adjustments relating to older process versions weren't working but I was able to resolve that myself. I'm going continue exploring for now but I might ask your opinion on a few things if you don't mind ;) I'll put that in a separate ticket though so we don't take this too far off-topic.

Regarding my comment about Adobe: there's no doubt their ecosystem of software is incredibly complex and obscure bugs like this are hard to avoid. My frustration stems from the fact that they've locked everyone into this subscription model and are no longer innovating as much as they used to. I don't want lots of new features but I expect the software to work reliably and continue to be refined. Lightroom is by definition a tool that people use for dealing with large volumes of files and it's disappointing that they haven't provided better extensibility or even just better shortcut options. Don't get me wrong, I'm grateful that it is possible to have options like VSCO Keys but surely it could be less of a battle to implement...

heyklaus commented 4 years ago

Also from me a big THANK YOU @cajames! I cannot emphasize enough how much your efforts help me in my daily workflow. Thank you very much for your relentless efforts 🙏

ilquare commented 4 years ago

Hey @cajames,

Thank you. I use Win10 and Lr9.3. Can you make version 2.0.5 for WIN? Thanks Stefano

Enricopez commented 4 years ago

thank @cajames for allowing us all to use VSCO keys, for me it has become a must have software 😅. Hoping you can always find the way on both Mac and WIN... Thanks 🙏

ilquare commented 4 years ago

Hi, is there any news? I would like to continue using LR9.3 with VSCO keys😅. Thanks 🙏