vshn / puppet-burp

BURP Backup Puppet Base Module
BSD 3-Clause "New" or "Revised" License
3 stars 6 forks source link

Add burp-ui to this module #6

Open kronos-pbrideau opened 8 years ago

kronos-pbrideau commented 8 years ago

Would you consider including it if I propose PR ? Or do you consider it out of scope of this module?

I've created the wheelhouse for internal use in my tests. No public internet is required to pip install. It would be an argument to use a custom wheelhouse when installing it, so no binary (*.whl) would be needed in this module.

  # NOTE: the wheelhouse was built with
  # pip wheel burp-ui
  file { '/opt/burp-ui_wheelhouse' :
    source  => 'puppet:///modules/burp-ui/wheelhouse',
    recurse => true,
  }

  package { 'python-pip' : }
  exec { 'install burp-ui' :
    require => [
      File['/opt/burp-ui_wheelhouse'],
      Package['python-pip'],
    ],
    command => 'pip install --use-wheel --no-index --find-link=/opt/burp-ui_wheelhouse burp-ui',
    unless  => 'pip freeze | grep "burp-ui"',
  }

I would also create the configure and service class. Would you have a naming convention to suggest? what do you think of:

manifests
├── burp-ui
│   ├── config.pp
│   ├── init.pp
│   ├── install.pp
│   └── service.pp
├── clientconfig.pp
├── client.pp
├── config.pp
├── extraconfig.pp
├── init.pp
├── install.pp
└── server.pp
tobru commented 8 years ago

It would be very great to have burp-ui managed by this Puppet module, so thanks for your suggestion. We prefer to have software packaged in OS package, f.e. Debian or RPM packages. So if you're able to package burp-ui and put it f.e. in a PPA on Launchpad, that would be very great. I'm happy to merge your work when you're finished.

kronos-pbrideau commented 8 years ago

Just to give a status, there is still no packages upstream, and i'm still using wheelhouse for installation, but once it get packaged upstream, it will be my first priority to include it in this module.

If someone want to try it and give me comments about the code, feel free to do so! Here is the branch: https://github.com/ktech-io/puppet-burp/tree/patch-burpui

tobru commented 7 years ago

@kronos-pbrideau Do you still plan to work on this? It's a rather old issue...