search

vt-elixir / ja_resource

A behaviour to reduce boilerplate code in your JSON-API compliant Phoenix controllers without sacrificing flexibility.
Other
113 stars 33 forks source link

fixes #69 #71

Closed joebew42 closed 6 years ago

joebew42 commented 7 years ago

Hi, I tried to fix this issue.

Now, the handle_delete is able to check for changeset validation errors and in case of errors it will respond with an unprocessable entity (http status 422).

swelham commented 6 years ago

@alanpeabody any chance on getting this merged?

alanpeabody commented 6 years ago

LGTM, @beerlington you good with it?

beerlington commented 6 years ago

Thanks! Somehow I missed this, but have been meaning to fix it for a while.

swelham commented 6 years ago

Awesome, thanks guys. Any idea on when the next version might get pushed to hex?