Prop for page header background color

vtex / shoreline

VTEX Design System for back-office experiences. Currently available for internal usage at VTEX.

https://shoreline.vtex.com

24 stars 1 forks source link

Open matheusps opened 3 weeks ago

matheusps commented 3 weeks ago

There are designs where the background is soft instead of base. This is not supported by the Page component by default.

Accept a variant on the page

<Page variant="soft | base">

No response

No response

beatrizmilhomem commented 3 weeks ago

Agreed!

renatamottam commented 3 weeks ago

Nice! This background is being used on dashboards proposals. It'll definitely help :)

davicostalf commented 3 weeks ago

Have we decided on changing the page header background color based on the page background. I'm all for it, but I remember there were hold outs.
I'm worried about calling this prop variant. We may have different types of page headers in the future, with differences other than just the background color.
One token is called bg-base and the other is bg-base-soft. Won't it be confusing for the prop values to be named soft and base?

lucasaarcoverde commented 3 weeks ago

One token is called bg-base and the other is bg-base-soft. Won't it be confusing for the prop values to be named soft and base?

I agree with that! Maybe we should take the primary and secondary approaches, which would open space for other variants