search

vtex / styleguide

The VTEX Design System and React component library.
https://styleguide.vtex.com
GNU General Public License v3.0
166 stars 33 forks source link

Image Uploader #415

Closed brunojdo closed 5 years ago

brunojdo commented 6 years ago

Overview

A component that allows the user to upload images. The component must have a way to configure max size and extensions(.jpg, .png) allowed.

Context

In PWA admin we need this component.

screen shot 2018-11-14 at 13 03 55

Examples

Pages Storefront have a sample of this component, Select the Carousel app to see. https://storecomponents.myvtex.com/admin/cms/storefront

cmdalbem commented 6 years ago

@brunojdo we have a proposal o design for this in the Figma Styleguide already! :) And from what I remember there are two other variations, designed by @TasGuerciMaia and @gabrielgalc, which might have even been developed already. This can be a great opportunity for us to have One Uploader To Rule Them All.

brunojdo commented 6 years ago

@cmdalbem We already have an image uploader in Pages and also in My account. Probably, it was based on @TasGuerciMaia and @gabrielgalc designs.

cmdalbem commented 6 years ago

@brunojdo so I guess it's just a matter of talking with these teams so they upload their components to the Styleguide, right?

cmdalbem commented 5 years ago

@ntmedina any news on that?

emersonlaurentino commented 5 years ago

A component called Dropzone was created for this in #671

I will close this issue because it has apparently been resolved. In the meantime, I will open a new issue that two new props be added to Dropzone that specify which extensions are allowed and what is the maximum file size.