vtorri / etui

Multi-document rendering library using the EFL
GNU General Public License v3.0
6 stars 5 forks source link

Considering using efl theme vs application specific #27

Open wltjr opened 7 years ago

wltjr commented 7 years ago

This is a request for consideration. I have spent a decent amount of time working on my own custom theme. Mostly modifications from another's. In a few cases like with Terminology. I had to also modify its theme file to match my theme. Not really ideal, but is what it is.

I am not sure that etui is using the theme file for much. I know it is in use for the initial background. Which is where I have my issue. I tried to take a screenshot, but soon as it loses focus, most the UI stuff I want to point out goes away.

Specifically I have changed blue to purple, and I have removed any shines. Thus in etui, I have a inside blue glow, and a shine at the top. The blue should be purple and no shine. I can modify the theme, and have a custom them file for etui for my theme. But honestly I rather not.

If possible I would like to explore options to see if there are others ways. Like using efl theme for such so it matches what ever theme the user has selected better. Without requiring a theme file for etui itself.

I know EFL can have per app theme files. But that is not really friendly to themers. Since they have to make a theme for EFL. Then go and match any changes to each app specific theme. ephoto is a good example. It uses a edc/edj file for effects but not really custom UI looks. Not all are as friendly. I need to look at verne's theme. But seems like may have some UI elements in its theme I will need to handle as well. Thus I rather not have to go around modifying a bunch of application theme files. Just to match the main EFL theme.

In entrance I was able to re-use the e desktop background. I think it is possible to do something along those lines with etui. If you are open to such I can see about making such changes and submitting a PR. Unless you want to do that yourself, either way. Hopefully receptive to such changes. Thanks!

vtorri commented 7 years ago

etui is using the theme for background, sound and sliding panel (same than terminology). Otherwise, I have 2 swallow for the doc itself and the elm filemanager.

About want you want to show, maybe a video of your desktop could show what you want to point out.

Honestly I don't have a lot of time because of work and family. So you can indeed submit a PR and I will see what it does.

thank you for your interest

wltjr commented 7 years ago

The theme can remain for sound and sliding. It is I think mostly the background for the file manager. When its centered in the window. I will see about making a video. Not very familiar with swallow but seems that is part of how the background is set in entrance. Where I am using e/desktop/background.

I will play around time permitting and submit a PR. Its not a major thing, minor UI annoyance. Most times I open a PDF directly, so I never see the file dialog. e.g. etui my.pdf