search

vtsuperdarn / davitpy

DEPRECATED The DaViT Python project
http://vtsuperdarn.github.com/davitpy/
GNU General Public License v3.0
37 stars 59 forks source link

field point calculation #344

Closed aburrell closed 6 years ago

aburrell commented 6 years ago

Field point calculation at large distances was breaking FoV plotting, since the more distant locations weren’t meeting the conditions for reliability. I fixed this by adding a flag that defaults to skipping this evaluation.

aburrell commented 6 years ago

This is the same bug fix that was added to the master branch in #324.

ksterne commented 6 years ago

OK, sorry it's taken me a bit, but since @aburrell tested my pull request, I figured I'd follow up here. Since it doesn't seem like there's been any changes since #324, I think this is good to go. I did pull the code again and ran it again to to confirm my results from the pull request into master.

aburrell commented 6 years ago

Thanks @ksterne ! @mts299 , do you want to take a quick look? Then I'll merge.

mts299 commented 6 years ago

Yup, I will look into it right now!

mts299 commented 6 years ago

Looks good to me, go ahead and merge it @aburrell

aburrell commented 6 years ago

Cheers everyone! Hitting the button.