[3.5.2] Transition stopped working after `3116553`

ferferga commented 4 weeks ago

Vue version

3.5.2

Link to minimal reproduction

https://github.com/jellyfin/jellyfin-vue

Steps to reproduce

Go to the repository, click on Code > Create codespace on master
cd frontend on terminal after Codespace boot
Run npm remove vue && npm i https://pkg.pr.new/vuejs/core/vue@311655352931863dfcf520b8cf29cebc5b7e1e00
Run npm run prod (or npm start) and load the frontend (on Ports tab there's a direct link)
On Add server screen, type https://demo.jellyfin.org/stable and click Connect. Check how the /server/login route doesn't appear.
Stop Vite and run npm remove vue && npm i https://pkg.pr.new/vuejs/core/vue@fca20a39aa4a6f98c8f972bd435ebb7dc535648a
Repeat the steps 4 and 5. In step 5, login with the credentials that are provided below the form (`demo``, empty password) to trigger as much navigations as you want inside the app, all of them will work properly.

What is expected?

Transitions keep working as before

What is actually happening?

Transitions stopped working and no warning or strange behaviour is displayed whatsoever, making it almost impossible to debug the issue.

System Info

No response

Any additional comments?

Sorry for not providing a minimal reproduction, but I was not able to isolate the issue in SFC Playground 😅. The "Change server" button in the screen shown at step 5 doesn't work, unrelated to this issue, but don't spend time debugging that, it's far easier to simply login and trigger navigations to trigger transitions.

cc @edison1105 (as the author of that commit)

edison1105 commented 3 weeks ago

@ferferga Could you please test this preview package to confirm your that problem not reproduce?

Edit: I tested it locally and the above issues have been fixed.

ferferga commented 3 weeks ago

@edison1105 Thank you very much for the quick fix as always 🚀.

Sorry for not providing feedback earlier, but was sleep time in my timezone.

vuejs / core