search

vuejs / vue-cli

🛠️ webpack-based tooling for Vue.js Development
https://cli.vuejs.org/
MIT License
29.75k stars 6.32k forks source link

Use package Husky instead of Yorkie in @vue/cli-plugin-eslint #6308

Open parreirat opened 3 years ago

parreirat commented 3 years ago

What problem does this feature solve?

Solves having a duplicated dependency for managing Githooks by projects using Husky, the forked-off package for Yorkie.

@vue/cli-plugin-eslint currently has a dependency on the Yorkie package

Yorkie (https://github.com/yyx990803/yorkie) is a 3 year old fork of Husky (https://github.com/typicode/husky)

As most people use Husky, and it's regularly maintained, I feel it's more advantageous to use Husky, as other people will not need to duplicate a dependency of Yorkie Husky, if they choose to use their own Githooks through Husky, due to the dependency of Yorkie on @vue/cli-plugin-eslint

Is there a specific reason Yorkie was chosen over Husky?

What does the proposed API look like?

No changes in API, just a package dependency.

Thanks, Tiago

P.S. - Was not completely sure where to report/present this, as there isn't a specific repo for the plugin that I found?

Maxim-Mazurok commented 3 years ago

Related: https://github.com/vuejs/vue-cli/issues/5686

Ziao commented 3 years ago

I would love to see this fixed as well. On a fresh install of our monorepo, this plugin is somehow overruling our Husky install in the root .git/hooks repository, which is unacceptable. Seeing how yorkie should be a devDepencency, I don't understand why it's listed in the regular dependencies, let alone why this plugin is relying on a very outdated package.

Sidenote, for me it's about @vue/cli-plugin-typescript