vuestorefront / vue-storefront-1

The open-source frontend for any eCommerce. Built with a PWA and headless approach, using a modern JS stack. We have custom integrations with Magento, commercetools, Shopware and Shopify and total coverage is just a matter of time. The API approach also allows you to merge VSF with any third-party tool like CMS, payment gateways or analytics. Newest updates: https://blog.vuestorefront.io. Always Open Source, MIT license.
https://www.vuestorefront.io
MIT License
18 stars 13 forks source link

vue-storefront.sh: not found when launching Docker container on Windows #212

Closed bloodf closed 3 years ago

bloodf commented 3 years ago

From vue-storefront created by dlejeune: vuestorefront/vue-storefront#5436

Current behavior

When following the "Getting Started" guide for the storefront, launching the docker container results in

/usr/local/bin/docker-entrypoint.sh: exec: line 8: vue-storefront.sh: not found

image

image

Expected behavior

The container should launch and run without errors.

Steps to reproduce the issue

Follow the instructions on the Getting Started on a Windows machine.

Version of Vue Storefront

Can you handle fixing this bug by yourself?

Which Release Cycle state this refers to? Info for developer. (doesn't apply to Next)

Pick one option.

Environment details

Additional information

I think this is caused by Windows Line Endings (CRLF) instead of Unix ones. I simply changed the line endings in vue-storefront.sh and the issue went away.

I spent quite a long time trying to debug this so thought creating the issue may help someone else. Maybe adding a note in the docs could help? Would be happy to do so.