vuestorefront / vue-storefront

Alokai is a Frontend as a Service solution that simplifies composable commerce. It connects all the technologies needed to build and deploy fast & scalable ecommerce frontends. It guides merchants to deliver exceptional customer experiences quickly and easily.

https://www.alokai.com

MIT License

10.63k stars 2.08k forks source link

feat: mg2 cli patch 4.1.0 #6903

Closed skirianov closed 1 year ago

skirianov commented 1 year ago

Changes as per issue #6899 and #6902

Add logging for whole CLI process
Fixed CLI without Magento 2 local installation
Add suggested name for Magento directory
Check and compare Magento dir name and VSF project dir name
Add instructions to cd into project name
Add yarn version check

Description

Related Issue

6899 #6902

Motivation and Context

Imporve overall DX and fix bug

How Has This Been Tested?

Manual QA

Screenshots:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read the CONTRIBUTING document.

Changelog

[ ] I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
[ ] I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

[ ] I have written test cases for my code
[ ] I have tested my Pull Request on production build and (to my knowledge) it works without any issues
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

I tested manually my code, and it works well with both:
[ ] Default Theme
[ ] Capybara Theme

Code standards

[x] My code follows the code style of this project.
[ ] I have followed naming conventions

Docs

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.