Avoid code repetition - Githubissues

vv9k / mobi-rs

A crate to work with MOBI format ebooks

MIT License

38 stars 10 forks source link

Avoid code repetition #1

Closed fogti closed 5 years ago

fogti commented 5 years ago

I tried to use rust macros to avoid some repetition.

Misc changes:

put contents of utils.rs into lib.rs
*HeaderData enums should be public if they aren't used in the public API

vv9k commented 5 years ago

Thank you very much for this pull request! I've learned a lot thanks to your code and re-did it myself :) I must say I've underestimated the power of macros!.

fogti commented 5 years ago

https://github.com/wojciechkepka/mobi-rs/blob/25862e33af3961cee7c96170fb96a539f89f6c84/src/lib.rs#L15 Tip: use ? (postfix) instead of this macro. docs

vv9k commented 5 years ago

Yes :) Thanks for that! finally understand how ? works