search

vv9k / podman-api-rs

Rust interface to Podman (libpod).
MIT License
84 stars 12 forks source link

Make the result stream of `Images::build` continuous #134

Closed marhkb closed 2 years ago

marhkb commented 2 years ago

What did you implement:

Currently, when the Images::build endpoint is called, no continuous stream is returned: once an image is successfully built, a single ImageBuildLibpod200Response is returned with the entire output of the build process.

This is especially bad for user interfaces, as no feedback can be provided to the user.

To make the stream continuous, the implementation of the endpoint is rewritten. Here, the implementation of the endpoint Images::pull is used as a template.

How did you verify your change:

I tested it locally: no stream item was returned before building was completed.

What (if anything) would need to be called out in the CHANGELOG for the next release:

(BREAKING) Make the result stream of Images::build continuous

vv9k commented 2 years ago

Awesome work, thanks for handling this.