vv9k / podman-api-rs

Rust interface to Podman (libpod).
MIT License
84 stars 12 forks source link

Exec detach #155

Closed bamboocleaver closed 1 year ago

bamboocleaver commented 1 year ago

What did you implement:

A fix for Exec::start() that expected the connection to be upgraded to TCP stream unconditionally.

How did you verify your change:

I use it in my project and it passes existing tests and an additional test specifically made to check my change (container_exec_detach).

bamboocleaver commented 1 year ago

Thanks for your suggestions :) I applied them and updated the changelog.

vv9k commented 1 year ago

LGTM, thank you :)