vvakame / language-review

Re:VIEW support for Atom
https://atom.io/packages/language-review
MIT License
27 stars 9 forks source link

Promise.done is deprecated. #33

Closed vvakame closed 8 years ago

vvakame commented 8 years ago

Atom now uses ES6 Promises instead of Q. Call promise.then instead of promise.done

Promise.done (/Applications/Atom.app/Contents/Resources/app.asar/src/atom.js:971:5)
Controller.togglePreview (/Users/vvakame/Dropbox/work/language-review/lib/language-review.js:108:12)
atom-workspace.<anonymous> (/Users/vvakame/Dropbox/work/language-review/lib/language-review.js:56:19)
CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:243:29)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61)
CommandPaletteView.confirmed (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/command-palette/lib/command-palette-view.js:159:32)
ledsun commented 6 years ago

バージョン 0.15.3 で同様の警告が出ました。

2018-02-21 9 49 36 2018-02-21 9 50 11