vvvv / VL.StandardLibs

A collection of standard libraries for vvvv including VL.Stride, VL.Skia, VL.ImGui, msgpack.org[VL]
https://visualprogramming.net
GNU Lesser General Public License v3.0
35 stars 14 forks source link

Uniform pins on ShaderFX nodes don't get updated sometimes #647

Open tebjan opened 1 year ago

tebjan commented 1 year ago

Describe the bug https://discourse.vvvv.org/t/integer-input-of-shaderfx-does-not-update/21635

It looks like the shader sink that builds the shader doesn't get the shader key/name for the pin of that ShaderFX node. This also happens when using ShaderFX nodes with MaterialExtension.

Example patch in the forums thread.

It works the stage keyword is added, but then you can only have one instance of a node per shader graph. because stage makes sure that there is only one variable of that name per compiled shader.

Is there an earlier version where this still works? maybe, hard to find out.

Additional context Might be related to other pin issues #75 #72 #70.

tebjan commented 3 days ago

Again in forums: https://discourse.vvvv.org/t/how-to-use-input-on-shaderfx-float3tofloat-node/22750