w3c / a11y-request

Horizontal review requests will be made via issues in this repo.
9 stars 2 forks source link

DeviceOrientation Event Specification 2024-01-29 > 2024-02-29 #71

Closed anssiko closed 5 months ago

anssiko commented 7 months ago

Other comments:

This spec initially reached CR in August 2016 (history) and was retired in 2017 due to the Geolocation WG closure. In 2019 DAS WG adopted this spec and during 2019-2024 made substantial interoperability, test automation, privacy and editorial improvements as outlined in the changes section.

These changes since the previous CR Snapshot from 2016 align the specification with widely available implementations, improve interoperability including testability, and add new features for enhanced privacy protections.

The Accessibility Checklist responses expand on a few areas that may benefit from your comment and review prior to our expected publication. Feedback on other aspects is also welcome.

Thank you for your accessibility review!

matatk commented 6 months ago

Hi @anssiko, thank you for your review request, and for the accessibility checklist info.

We discussed this in an APA call recently; we think that there are some accessibility considerations, and that a section on them would be a helpful addition to your spec. We'd be happy to help you in drafting an accessibility considerations section, and look forward to working with you again. Below is a summary of our thoughts.

Would you like us to file either one combined issue in your spec's repo for all of these, or a separate issue for each part?

Here are the main things we would ask developers who are building things with the spec to consider:

There are two further things that are out of scope of things built with the spec, but it could be helpful for developers to understand why these can present barriers to people (possibly a wider range of people than they were expecting):

I'm not sure if this fits within scope (it sounds like it is possible to query the current orientation, as well as to be notified when it changes), but it may be worth noting that web content must work (i.e. be functionally equivalent) regardless of the orientation of the device - that is intended to support the use of devices that may be mounted, e.g. in a fixed position on a wheelchair or somewhere else such that the user doesn't need to hold the device in order to interact with it.

anssiko commented 6 months ago

@matatk much thanks for your in-depth review and comments.

Would you like us to file either one combined issue in your spec's repo for all of these, or a separate issue for each part?

Given all these insights seem to contribute toward an accessibility considerations section, it would be good to capture this in one issue that will then be addressed with a PR that adds these considerations to the spec. You can set this as an expectation when you open the issue.

The DAS WG would be happy to receive a draft PR or explicit text the editors can integrate on behalf of APA WG. We'd love to get accessibility consideration incorporated into the March CR Snapshot. Your existing contribution is almost ready to be integrated as is with some editorial tweaking. As a11y experts, you can own the a11y considerations section and have editorial freedom there.

matatk commented 6 months ago

@anssiko: We are running a call for consensus on our proposed section. If it's successful, we'll be able to make a PR next week.

You're welcome - our comment is of course a team effort, but I should also mention that @niklasegger did a lot of the ground work on it.

anssiko commented 6 months ago

Thanks to the entire a11y team for your work on this. It sounds like your contribution will arrive just in time for the CR Snapshot.

anssiko commented 6 months ago

@matatk @niklasegger I hope you're doing great. We're eagerly waiting for your PR to integrate it into the upcoming CRS. Please let us know if you have a draft text available that passed CfC. If you like, we can take care of massaging it into a PR on your behalf and can iterate on the PR together. Thank you for working with us on this!

matatk commented 5 months ago

Hi @anssiko. We do have an APA consensus text; here it is, for convenience. However, I am happy to make a PR now we have the text; please ping me if you'd like me to do that.


Accessibility Considerations

DeviceOrientation events provide opportunities for novel forms of input, which can open up novel interactions for users. In order to ensure that as many people as possible will be able to interact with the experiences you build, please consider the following.

There are two user needs that can arise, which would likely be managed by the UA, or underlying Operating System. However, it can be helpful to bear these considerations in mind, as they represent ways that your content or app may be used.

anssiko commented 5 months ago

@matatk to make it easier for you, here's a PR for your review: https://github.com/w3c/deviceorientation/pull/150

Thank you @matatk & APA folks for your significant contribution!

matatk commented 5 months ago

This is closed with the merging of w3c/deviceorientation#150.

We look forward to the next time we get to work with you and your group, @anssiko :-).